Update dependencies and enhance Polkasafe repository functionality#1510
Open
AleemAlam wants to merge 2 commits intoAstarNetwork:fix/polkadot-typesfrom
Open
Update dependencies and enhance Polkasafe repository functionality#1510AleemAlam wants to merge 2 commits intoAstarNetwork:fix/polkadot-typesfrom
AleemAlam wants to merge 2 commits intoAstarNetwork:fix/polkadot-typesfrom
Conversation
- Upgraded `polkasafe` to version 1.5.0 and added `react` and `react-dom` dependencies. - Introduced new `getMultisigTransaction` method in `IPolkasafeRepository` to retrieve multisig transactions. - Updated `PolkasafeRepository` to implement the new method, improving transaction handling. - Refactored `PolkadotWalletService` to utilize the new `getMultisigTransaction` method, enhancing the wallet's transaction capabilities. - Adjusted various types and parameters for better clarity and functionality.
- Introduced ProxyAccount interface to better manage proxy accounts in multisig. - Updated MultisigAddress to support an array of proxy accounts and added a new multisigAddress field. - Refactored addProxyAccounts function to handle multiple proxy accounts and sort signatories. - Modified PolkadotWalletService to utilize the new multisigAddress for proxy accounts, improving address handling in transactions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
polkasafeto version 1.5.0 and addedreactandreact-domdependencies.getMultisigTransactionmethod inIPolkasafeRepositoryto retrieve multisig transactions.PolkasafeRepositoryto implement the new method, improving transaction handling.PolkadotWalletServiceto utilize the newgetMultisigTransactionmethod, enhancing the wallet's transaction capabilities.Pull Request Summary
Check list
This pull request makes the following changes:
Adds
Fixes
Changes
To-dos